david/ipxe
david
/
ipxe
Archived
1
0
Fork 0
Code

[netdevice] Report network-layer errors via network device statistics 

Errors generated by the network layer in response to received packets
are liable to be lost, since nothing systematically records these
errors and often the packets do not propagate far enough through the
stack to impact upon user-visible processes.

Improve this situation by recording network-layer errors in the
network device statistics.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown 2010-09-15 04:56:28 +01:00
parent dace106f82
commit 85a3169967
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/net/netdevice.c
View File

@ -658,7 +658,7 @@ int net_rx ( struct io_buffer *iobuf, struct net_device *netdev,
DBGC ( netdev, "NETDEV %p unknown network protocol %04x\n",
netdev, ntohs ( net_proto ) );
free_iob ( iobuf );
return 0;
return -ENOTSUP;
}
/**
@ -705,7 +705,12 @@ static void net_step ( struct process *process __unused ) {
continue;
}
net_rx ( iobuf, netdev, net_proto, ll_source );
/* Hand packet to network layer */
if ( ( rc = net_rx ( iob_disown ( iobuf ), netdev,
net_proto, ll_source ) ) != 0 ) {
/* Record error for diagnosis */
netdev_rx_err ( netdev, NULL, rc );
}
}
}
}