From 85a3169967350fb92548a3e50ec7c533b27f407b Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Wed, 15 Sep 2010 04:56:28 +0100 Subject: [PATCH] [netdevice] Report network-layer errors via network device statistics Errors generated by the network layer in response to received packets are liable to be lost, since nothing systematically records these errors and often the packets do not propagate far enough through the stack to impact upon user-visible processes. Improve this situation by recording network-layer errors in the network device statistics. Signed-off-by: Michael Brown --- src/net/netdevice.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/net/netdevice.c b/src/net/netdevice.c index 51bd344b..bb8a5b28 100644 --- a/src/net/netdevice.c +++ b/src/net/netdevice.c @@ -658,7 +658,7 @@ int net_rx ( struct io_buffer *iobuf, struct net_device *netdev, DBGC ( netdev, "NETDEV %p unknown network protocol %04x\n", netdev, ntohs ( net_proto ) ); free_iob ( iobuf ); - return 0; + return -ENOTSUP; } /** @@ -705,7 +705,12 @@ static void net_step ( struct process *process __unused ) { continue; } - net_rx ( iobuf, netdev, net_proto, ll_source ); + /* Hand packet to network layer */ + if ( ( rc = net_rx ( iob_disown ( iobuf ), netdev, + net_proto, ll_source ) ) != 0 ) { + /* Record error for diagnosis */ + netdev_rx_err ( netdev, NULL, rc ); + } } } }