david/ipxe
Archived
1
0
This repository has been archived on 2020-12-06. You can view files and clone it, but cannot push or open issues or pull requests.
ipxe/src/net/udp
Joshua Oreman 49d6f57005 [compiler] Prevent empty weak function stubs from being removed
Even with the noinline specifier added by commit 1a260f8, gcc may skip
calls to non-inlinable functions that it knows have no side
effects. This caused the get_cached_dhcpack() call in start_dhcp(),
the weak stub of which has no code in its body, to be removed,
preventing cached DHCP from working.

Fix by adding a __keepme macro to compiler.h expanding to asm(""), as
recommended by gcc's info page, and using it in the weak stub for
get_cached_dhcpack().

Reported-by: Aaron Brooks <aaron@brooks1.net>
Tested-by: Aaron Brooks <aaron@brooks1.net>
Signed-off-by: Joshua Oreman <oremanj@rwcr.net>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
2010-08-19 13:37:52 +01:00
..
dhcp.c [compiler] Prevent empty weak function stubs from being removed 2010-08-19 13:37:52 +01:00
dns.c [interface] Convert all data-xfer interfaces to generic interfaces 2010-06-22 15:50:31 +01:00
slam.c [interface] Convert all data-xfer interfaces to generic interfaces 2010-06-22 15:50:31 +01:00
tftp.c [interface] Convert all data-xfer interfaces to generic interfaces 2010-06-22 15:50:31 +01:00