632e57f0f3
The SNP device path includes the network device's MAC address within the MAC_ADDR_DEVICE_PATH.MacAddress field. We check that the link-layer address will fit within this field, and then perform the copy using the length of the destination buffer. At 32 bytes, the MacAddress field is actually larger than the current maximum iPXE link-layer address. The copy therefore overflows the source buffer, resulting in trailing garbage bytes being appended to the device path's MacAddress. This is invisible in debug messages, since the DevicePathToText protocol will render only the length implied by the interface type. Fix by copying only the actual length of the link-layer address (which we have already verified will not overflow the destination buffer). Debugged-by: Laszlo Ersek <lersek@redhat.com> Signed-off-by: Michael Brown <mcb30@ipxe.org> |
||
|---|---|---|
| .. | ||
| arch | ||
| bin | ||
| config | ||
| core | ||
| crypto | ||
| doc | ||
| drivers | ||
| hci | ||
| image | ||
| include | ||
| interface | ||
| libgcc | ||
| net | ||
| scripts | ||
| tests | ||
| usr | ||
| util | ||
| .gitignore | ||
| doxygen.cfg | ||
| Makefile | ||
| Makefile.efi | ||
| Makefile.housekeeping | ||