david/ipxe
david/ipxe
Archived
1
0
Fork 0
Code
1,532 Commits 1 Branch 0 Tags 14 MiB
bcdb6fad3e
Commit Graph

228 Commits

Author SHA1 Message Date
Michael Brown
feb4f65d1e Use auto-colourisation for debug messages. 
Truncate TX length to TCP window at time of transmission rather than at
time of adding to TX packet; this is conceptually cleaner and also allows
the application to call tcp_send() multiple times to build up a single
packet.
 2006-12-29 14:03:03 +00:00
Michael Brown
ce9819af27 Redefine TCP state to include "flags that have been sent" rather than 
"flags that are currently being sent".  This allows at least one special
case (checking that we haven't already sent a FIN in tcp_rx_fin()) to be
collapsed.
 2006-12-29 00:44:31 +00:00
Michael Brown
be31970e36 Don't send a second FIN if we receive a FIN while in FIN_WAIT_2 2006-12-27 23:44:05 +00:00
Michael Brown
61ed298bc7 Merge changes from mcb-tcp-fixes branch. 2006-12-27 23:09:46 +00:00
Michael Brown
1a11cc5c5b Added times to start/stop log messages 2006-12-27 22:56:39 +00:00
Michael Brown
4cc1c1bd4c Ensure that old TCP connection state is destroyed before attempting to 
reopen connection.  (The TCP API will soon change to render this step
unnecessary.)
 2006-12-22 13:04:50 +00:00
Michael Brown
a2e3357825 Cannot immediately overwrite the peer address when we parse 
TargetAddress from the login response, because we still need the old
address while we close the connection!
 2006-12-22 12:24:12 +00:00
Michael Brown
66a7ed23cb Make start_timer() and stop_timer() robust against incorrect usage. 2006-12-22 01:35:21 +00:00
Michael Brown
d6f9152bfa Avoid null pointer dereferences when no username/password specified. 2006-12-21 18:38:24 +00:00
Michael Brown
6ceb55fad0 When login fails, leave the session open but not in full feature 
phase.  In iscsi_issue(), detect this state and immediately refuse the
operation.  This avoids trying multiple logins when scsi.c tries
several times to read the drive capacity.
 2006-12-21 17:43:43 +00:00
Michael Brown
ab242a760d Add ability to shut down iSCSI connection 2006-12-21 17:17:47 +00:00
Michael Brown
60a3f77711 Close UDP connection when DHCP completes. 2006-12-20 07:19:48 +00:00
Michael Brown
a646e38f03 Use stdlib.h for malloc() instead of malloc.h. 2006-12-19 23:42:46 +00:00
Michael Brown
04c09823bd Request all the options that we're prepared to do anything with. 2006-12-12 16:18:20 +00:00
Michael Brown
a1af111a87 Also request root-path. 2006-12-08 15:49:46 +00:00
Michael Brown
38ae94f8ce A cleaner method of handling login redirection; just use the existing 
reconnection mechanism.  This avoids the problems of trying to reuse
the TCP connection structure before the old connection has cleanly exited.
 2006-12-06 19:53:56 +00:00
Michael Brown
5edb85c8b4 Work around another confused-by-RST bug 2006-12-06 18:09:33 +00:00
Michael Brown
b9f9230661 Work around another instance of the port re-use bug. 2006-12-05 23:15:35 +00:00
Michael Brown
8c3d09c564 Tweaked retry messages 2006-12-05 23:12:54 +00:00
Michael Brown
9600af14a3 Added debug messages 2006-12-05 22:53:49 +00:00
Michael Brown
cc0b92652f Call closed() method only when the connection is genuinely in the 
TCP_CLOSED state (i.e. after the final FIN/ACK exchange), and has been
removed from the list of TCP connections.
 2006-12-05 22:53:28 +00:00
Michael Brown
fcc70c9d60 Ensure that tcp_rx() always frees its received packet buffer. 2006-12-05 21:23:23 +00:00
Michael Brown
28c711b91d Killed off spurious <stdio.h> inclusion 2006-12-05 21:16:52 +00:00
Michael Brown
3fbfbad0f7 Avoid calling NULL methods! 2006-12-05 21:09:37 +00:00
Michael Brown
89bcb57201 Update ftp.c to work with Nikhil's TCP stack. 
Remove the now-totally-obsolete sockaddr_in field from tcp.h.
 2006-12-05 19:07:47 +00:00
Michael Brown
6842dd3222 Handle TargetAddress 2006-12-05 01:41:32 +00:00
Michael Brown
67577556a2 Handle strings as complete units, instead of a byte at a time. 2006-12-05 01:08:56 +00:00
Michael Brown
3a7d762c1c Add iscsi_rx_buffered_data() and supporting infrastructure. 2006-12-05 00:39:05 +00:00
Michael Brown
3f0b4d9ed8 Updated to use asynchronous operation model for iSCSI requests 
Added CHAP authentication
 2006-11-28 00:29:02 +00:00
Michael Brown
fedc186fd7 Split login into security negotation and operational parameter 
negotiation phases, to allow inclusion of CHAP authentication.
 2006-10-03 09:17:38 +00:00
Michael Brown
88e38fa148 We don't actually have a stdio.h header file. Our printf() functions are 
defined in vsprintf.h.  (This may change, since vsprintf.h is a
non-standard name, but for now it's the one to use.)

There should be no need to include vsprintf.h just for DBG() statements,
since include/compiler.h forces it in for a debug build anyway.
 2006-09-27 10:58:14 +00:00
Marty Connor
6ac78f6aff added stdio.h to includes for DBG compilation 2006-09-27 05:57:06 +00:00
Michael Brown
0dca1dc8ce Made eth_ntoa() public for use in legacy drivers' DBG() statements. 2006-09-15 12:34:34 +00:00
Michael Brown
095fce14f8 Added extra debugging 2006-08-30 13:39:07 +00:00
Michael Brown
cab3f4502b Correct option number for DHCP_DNS_SERVERS, and add it to the request 
list.
 2006-08-27 01:37:58 +00:00
Nikhil Chandru Rao
dccb8358bd Fixed a bug in the TCP state machine. Added a transition from ESTABLISHED to LAST_ACK on receiving a FIN,ACK 2006-08-19 16:14:53 +00:00
Nikhil Chandru Rao
d1d334b8e1 IP6 support 2006-08-19 15:58:22 +00:00
Michael Brown
f1e1dfae3d Added RX tracing as well. 2006-08-16 00:15:40 +00:00
Michael Brown
0743dc5b0d Added some minimal debugging for transmitted PDUs. 2006-08-15 23:56:18 +00:00
Derek Pryor
562ab6d65c Bug fixes to the HTTP protocol code 2006-08-12 19:05:08 +00:00
Derek Pryor
0f88703019 Bug fixes to the HTTP protocol code 2006-08-12 18:54:59 +00:00
Michael Brown
db0ff1731f Fail gracefully when set_dhcp_option() is called with options==NULL. 2006-08-11 18:16:34 +00:00
Derek Pryor
25ea34a8d7 New HTTP protocol and test code 2006-08-11 14:13:02 +00:00
Michael Brown
2497270c14 command->data_{in,out} are now userptr_t, so it is invalid to compare 
against NULL.
 2006-08-10 17:35:14 +00:00
Michael Brown
ea5fa82b91 Fixed variable name in assertion 2006-08-10 17:09:48 +00:00
Michael Brown
c3a4f3c5da Towards an RFC2988-compliant timer. 2006-08-09 15:54:17 +00:00
Michael Brown
f0718d562f Don't call stop_timer() from within the timer expiry callback; it's 
already stopped.

Don't call start_timer() when sending a dataless ACK.  This may or may
not be the right thing to do; I can't tell.

Back out broken "send ACK only if required to" logic temporarily.
 2006-08-09 15:50:20 +00:00
Nikhil Chandru Rao
3aff701001 Changed the TCP state machines behaviour in the ESTABLISHED state 2006-08-09 15:04:26 +00:00
Michael Brown
dc8b96b446 Temporarily work around the bug when port numbers are reused between 
subsequent runs.
 2006-08-09 14:44:58 +00:00
Michael Brown
09688cb3b5 Correct some packet ownership and freeing bugs. 2006-08-09 14:27:07 +00:00
Michael Brown
43d601b678 out_flags was being set but never used. 
Use just random() to allocate initial sequence numbers; the previous
algorithm ended up with a high probability of zeroing the high word.
 2006-08-09 13:35:03 +00:00
Michael Brown
065a2a486d Port the UDP port allocation code to TCP 2006-08-09 12:08:20 +00:00
Michael Brown
de0c36a98a Remove some of the confusion surrounding the amount to strip off from 
a TCP packet before passing to newdata().
 2006-08-09 12:01:09 +00:00
Michael Brown
867c7aef59 iphdr->hlen includes the IP header, so truncate packet *before* 
stripping the header.  Also fix an htons/ntohs confusion.
 2006-08-09 11:52:53 +00:00
Marty Connor
ee9ae8130a Remove _PROTOCOL macros for gcc 3.2 compatibility 2006-08-09 04:42:14 +00:00
Michael Brown
e9561aafc0 Derive xid dynamically from the netdev, so that we can call 
create_dhcp_packet() from pxe_preboot.c, after the dhcp_session is long
gone.

Expose the functions required by pxe_preboot.c
 2006-08-09 02:56:40 +00:00
Michael Brown
a3d508b648 Clarified packet ownership transfer between a few functions. 
Added a large number of missing calls to free_pkb().  In the case of UDP,
no received packets were ever freed, which lead to memory exhaustion
remarkably quickly once pxelinux started up.

In general, any function with _rx() in its name which accepts a pk_buff
*must* either call free_pkb() or pass the pkb to another _rx() function
(e.g. the next layer up the stack).  Since the UDP (and TCP) layers don't
pass packet buffers up to the higher-layer protocols (the
"applications"), they must free the packet buffer after calling the
application's newdata() method.
 2006-08-09 01:24:32 +00:00
Michael Brown
d1a123b1f4 Added TFTP test code (currently just dumps file to console). 2006-08-09 00:09:29 +00:00
Michael Brown
3611cb17b7 Initial (untested) implementation of TFTP over the new UDP API. 2006-08-08 23:45:52 +00:00
Nikhil Chandru Rao
409f69a08a Changed ipv4_dump() to consume only one line. 2006-08-08 22:26:35 +00:00
Nikhil Chandru Rao
8bf38fb400 Corrected bugs in the TCP logic. There might be a few more which need to be taken care of. 2006-08-08 22:25:20 +00:00
Michael Brown
68e33224ef gcc3 compatibility: removed ARP_NET_PROTOCOL(). 2006-08-08 17:44:25 +00:00
Nikhil Chandru Rao
d2bdf81505 Removed some bugs in TCP 2006-08-08 03:42:30 +00:00
Nikhil Chandru Rao
cb42e573a0 Added retransmissions to TCP 2006-08-07 18:52:26 +00:00
Michael Brown
885a630ddf Fix routing when a gateway exists. This should probably be split into 
a separate function.
 2006-08-07 17:51:19 +00:00
Michael Brown
d0e4f198d6 Add iSCSI to the DHCP tests. 
Start updating iscsi.c to use Nikhil's TCP API.
 2006-08-07 16:48:24 +00:00
Nikhil Chandru Rao
6714ec745a Minor corrections 2006-08-07 07:37:23 +00:00
Michael Brown
eb24eece0e Convert some trivial functions to static inlines. 2006-08-03 23:42:03 +00:00
Michael Brown
ffe0e24249 Make the UDP senddata() methods return a status code. 
udp_connect() now follows the standard BSD sockets semantics and simply
sets the default address for outgoing packets; it doesn't filter incoming
packets.
 2006-08-03 23:10:14 +00:00
Michael Brown
a0a872f7f1 Updated PXE UDP implementation to use the new Etherboot UDP API. 
Updated PXE API dispatcher to use copy_{to,from}_user, and moved to
arch/i386 since the implementation is quite architecture-dependent.
(The individual PXE API calls can be largely
architecture-independent.)
 2006-08-02 23:08:10 +00:00
Michael Brown
467e9627cc Added features that will be required for PXE UDP support. 
Introduced struct sockaddr_tcpip, to simplify code that deals with
both IPv4 and IPv6 addresses.

Reorganised parts of tcpip.c and udp.c.
 2006-08-02 00:02:21 +00:00
Nikhil Chandru Rao
9225f4edac TCP support 2006-08-01 20:46:50 +00:00
Nikhil Chandru Rao
c24546c70b Minor changes to the network layer rx() functions 2006-08-01 20:27:26 +00:00
Michael Brown
beadd82208 Remove unused functions. 2006-08-01 14:26:02 +00:00
Michael Brown
1ebb68e49a Renamed trans_{rx,tx}() to tcpip_{rx,tx}(), since they are specific to 
the TCP/IP protocol suite (rather than being general transport-layer
functions).
 2006-08-01 14:22:04 +00:00
Michael Brown
3a0e293123 Renamed tcpip_if.[ch] to tcpip.[ch] 2006-08-01 14:18:09 +00:00
Michael Brown
21c3d63c2e We shouldn't need to allocate a TX packet buffer when calling newdata(); 
if the application wants to send data then it will have to use the normal
senddata() mechanism.
 2006-08-01 14:13:58 +00:00
Michael Brown
ae277992c2 Request bootfile name; it doesn't seem to be automatically supplied by 
all servers.
 2006-08-01 14:12:27 +00:00
Michael Brown
3085f03ad4 Request Etherboot encapsulated options. 
Parameter request list is yet another option that ISC dhcpd ignores
unless it's in the main options block.

Fix logic error in parsing file and sname fields.
 2006-07-20 14:14:41 +00:00
Michael Brown
b26806cf18 Add dhcp_snprintf() for extracting DHCP string options. 2006-07-20 14:13:11 +00:00
Michael Brown
16d04386b6 Switch default stack to Nikhil's TCP/IP stack 2006-07-20 02:53:15 +00:00
Michael Brown
e74e20cb55 Remove the static IP address hack from netdevice.c, and change the 
default test to the DHCP test.
 2006-07-20 02:51:52 +00:00
Michael Brown
00a1f000b1 Added dhcp_ipv4_option() and friends. 
Added test code to configure the interface for IPv4 after DHCP.
 2006-07-20 02:49:59 +00:00
Michael Brown
6a0b4c9772 Free up any allocated options if we fail 2006-07-20 02:25:39 +00:00
Michael Brown
764cb41456 Document memory ownership. 2006-07-20 02:23:42 +00:00
Michael Brown
7ca1bb0fbe Now successfully negotiates the whole DHCPDISCOVER/OFFER/REQUEST/ACK 
cycle.  :)
 2006-07-20 02:19:06 +00:00
Michael Brown
30d9bcdc6e Rename unwieldy function 2006-07-20 00:24:25 +00:00
Michael Brown
9ad5cede96 Set DHCP_MESSAGE_TYPE option within the main options block. This 
doesn't seem to be required by the RFCs, but at least ISC dhcpd and
ethereal refuse to recognise it otherwise.
 2006-07-20 00:18:50 +00:00
Michael Brown
881b90e82c Packets without a DHCP_MESSAGE_TYPE option are probably just BOOTP 
packets.
 2006-07-20 00:03:25 +00:00
Michael Brown
29b358dd39 conn->local_port is now network-endian; do not swap when comparing 
against value in header.

Temporarily disable RX checksumming; it's broken and is holding up
work on higher-layer protocols
.
 2006-07-20 00:03:01 +00:00
Michael Brown
36c94eae78 Clarify hexiness of header length 2006-07-20 00:01:50 +00:00
Michael Brown
2c0eb6eb1d Correct TCP/IP checksum generation. 2006-07-19 23:38:05 +00:00
Michael Brown
0768670fd8 udp_open() takes ports in network-endian order. 2006-07-19 21:56:27 +00:00
Nikhil Chandru Rao
13dbf5494d Minor edits 2006-07-19 21:05:58 +00:00
Michael Brown
224529d8dd Now capable of sending what, to me, looks like a valid DHCPDISCOVER 
(apart from the bad UDP checksum).
 2006-07-19 20:50:50 +00:00
Michael Brown
a38010fb0e Make udp_send() call udp_sendto(), rather than vice-versa. 2006-07-19 20:38:49 +00:00
Michael Brown
7c84b74185 A small but very critical bug. 2006-07-19 20:16:46 +00:00
Michael Brown
82f3295794 Use more standardised format specifiers in debug messages (e.g. %p for 
a pointer).
 2006-07-19 18:45:18 +00:00
Michael Brown
ab633f6a73 Reserve space for lower-layer headers when allocating packet buffer. 
Use pkb_available() rather than pkb_len() (which will always return 0
on a freshly allocated buffer).

udp_send() should assume that the buffer has already been allocated.
 2006-07-19 18:21:30 +00:00
Michael Brown
e8daeb62b1 Eliminate confusion between functions that return pointers and 
functions that return status codes.

Zero the DHCP packet buffer *before* creating the options structures
inside it.
 2006-07-19 18:11:31 +00:00