From f7c5918b179be57fc7f352cb33664eb43de02c30 Mon Sep 17 00:00:00 2001 From: Bruce Rogers Date: Fri, 2 Apr 2010 18:16:38 -0600 Subject: [PATCH] [drivers] Fix warnings identified by gcc 4.5 In building gpxe for openSUSE Factory (part of kvm package), there were a few problems identified by the compiler. This patch addresses them. Signed-off-by: Bruce Rogers Signed-off-by: Stefan Hajnoczi Signed-off-by: Marty Connor --- src/drivers/net/ath5k/ath5k_qcu.c | 2 +- src/drivers/net/ns83820.c | 2 +- src/drivers/net/tulip.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/drivers/net/ath5k/ath5k_qcu.c b/src/drivers/net/ath5k/ath5k_qcu.c index a674b85b..cb250293 100644 --- a/src/drivers/net/ath5k/ath5k_qcu.c +++ b/src/drivers/net/ath5k/ath5k_qcu.c @@ -268,7 +268,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah) } if (tq->tqi_ready_time && - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB)) + (tq->tqi_type != AR5K_TX_QUEUE_CAB)) ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time, AR5K_QCU_RDYTIMECFG_INTVAL) | AR5K_QCU_RDYTIMECFG_ENABLE, diff --git a/src/drivers/net/ns83820.c b/src/drivers/net/ns83820.c index 44d875fb..c5f21538 100644 --- a/src/drivers/net/ns83820.c +++ b/src/drivers/net/ns83820.c @@ -687,7 +687,7 @@ static int ns83820_poll(struct nic *nic, int retrieve) // rx_ring[entry].link = 0; rx_ring[entry].cmdsts = cpu_to_le32(CMDSTS_OWN); - ns->cur_rx = ++ns->cur_rx % NR_RX_DESC; + ns->cur_rx = (ns->cur_rx + 1) % NR_RX_DESC; if (ns->cur_rx == 0) /* We have wrapped the ring */ kick_rx(); diff --git a/src/drivers/net/tulip.c b/src/drivers/net/tulip.c index e08e0d84..af30ec64 100644 --- a/src/drivers/net/tulip.c +++ b/src/drivers/net/tulip.c @@ -1171,7 +1171,7 @@ static int tulip_poll(struct nic *nic, int retrieve) if (rx_ring[tp->cur_rx].status & 0x00008000) { /* return the descriptor and buffer to receive ring */ rx_ring[tp->cur_rx].status = 0x80000000; - tp->cur_rx = (++tp->cur_rx) % RX_RING_SIZE; + tp->cur_rx = (tp->cur_rx + 1) % RX_RING_SIZE; return 0; } @@ -1180,7 +1180,7 @@ static int tulip_poll(struct nic *nic, int retrieve) /* return the descriptor and buffer to receive ring */ rx_ring[tp->cur_rx].status = 0x80000000; - tp->cur_rx = (++tp->cur_rx) % RX_RING_SIZE; + tp->cur_rx = (tp->cur_rx + 1) % RX_RING_SIZE; return 1; }