david/ipxe
david
/
ipxe
Archived
1
0
Fork 0
Code

[zbin] Fix size used for memset in alloc_output_file 

The output->buf field is a pointer, not an array, so sizeof() is not
applicable.  We must use the allocated string length instead.

Identified by gcc:

  util/zbin.c: In function ‘alloc_output_file’:
  util/zbin.c:146:37: warning: argument to ‘sizeof’ in ‘memset’ call
    is the same expression as the destination; did you mean to
    dereference it? [-Wsizeof-pointer-memaccess]
  memset ( output->buf, 0xff, sizeof ( output->buf ) );

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Daniel P. Berrange 2013-03-05 15:18:20 +00:00 committed by Michael Brown
parent 9373ca8ea2
commit eb5a2ba596
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/util/zbin.c
View File

@ -143,7 +143,7 @@ static int alloc_output_file ( size_t max_len, struct output_file *output ) {
max_len );
return -1;
}
memset ( output->buf, 0xff, sizeof ( output->buf ) );
memset ( output->buf, 0xff, max_len );
return 0;
}