From e09331a4c6731b771c60f554f33cf0fdf5775124 Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Wed, 7 Dec 2016 07:25:44 +0000 Subject: [PATCH] [undi] Try matching UNDI ROMs in BIOS enumeration order When searching for an UNDI ROM to match against a PCI device, search in order of increasing ROM address (within the 128kB BIOS option ROM area). This is likely (though not guaranteed) to match the order of the original enumeration performed by the BIOS, which is in turn likely to match the order of enumeration on the PCI bus. Since we load at most one UNDI ROM, the net result is that we increase our chances of loading the ROM corresponding to the selected PCI device (rather than loading a ROM corresponding to a higher-numbered PCI device with the same vendor and device IDs.) Signed-off-by: Michael Brown --- src/arch/x86/drivers/net/undirom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/arch/x86/drivers/net/undirom.c b/src/arch/x86/drivers/net/undirom.c index b54c6170..257b1241 100644 --- a/src/arch/x86/drivers/net/undirom.c +++ b/src/arch/x86/drivers/net/undirom.c @@ -168,7 +168,7 @@ static int undirom_probe ( unsigned int rom_segment ) { /* Add to UNDI ROM list and return */ DBGC ( undirom, "UNDIROM %p registered\n", undirom ); - list_add ( &undirom->list, &undiroms ); + list_add_tail ( &undirom->list, &undiroms ); return 0; err: