From b4a87daeb92453e5ae35e001bd0c477f41aea8a3 Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Thu, 16 Apr 2009 06:13:09 +0100 Subject: [PATCH] [build] Simplify use of Getopt::Long in padimg.pl Sometimes it's just so much fun doing things the complicated way that you forget to check the man page for the existence of a simpler syntax. --- src/util/padimg.pl | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/util/padimg.pl b/src/util/padimg.pl index 71d0eee8..4421aaf4 100755 --- a/src/util/padimg.pl +++ b/src/util/padimg.pl @@ -9,16 +9,15 @@ my $verbosity = 0; my $blksize = 512; my $byte = 0; -my $opts = { +my %opts = ( 'verbose|v+' => sub { $verbosity++; }, 'quiet|q+' => sub { $verbosity--; }, 'blksize|s=o' => sub { $blksize = $_[1]; }, 'byte|b=o' => sub { $byte = $_[1]; }, -}; +); Getopt::Long::Configure ( 'bundling', 'auto_abbrev' ); -GetOptions ( { map { /^(\w+)/; $1 => $opts->{$_} } keys %$opts }, keys %$opts ) - or die "Could not parse command-line options\n"; +GetOptions ( %opts ) or die "Could not parse command-line options\n"; while ( my $filename = shift ) { die "$filename is not a file\n" unless -f $filename;