david/ipxe
david
/
ipxe
Archived
1
0
Fork 0
Code

[forcedeth] Remove software unicast MAC address filter 

The forcedeth driver currently implements unicast MAC address
filtering in software.  This is almost invariably the wrong thing to
do (since the network stack must already be able to cope with unwanted
packets) and it breaks FCoE (which requires the card to operate in
promiscuous mode).

Also, the implementation is buggy: is_local_ether_addr() is used to
check for a locally-assigned Ethernet address (not to check for a
unicast address), and the current link-layer address is in
netdev->ll_addr, not netdev->hw_addr.

Fix by removing this code.

Reported-by: Tal Aloni <tal.aloni.il@gmail.com>
Tested-by: Tal Aloni <tal.aloni.il@gmail.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown 2011-03-29 21:55:04 +01:00
parent fe61f6de0d
commit 797c29adda
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/drivers/net/forcedeth.c
View File

@ -934,15 +934,8 @@ nv_process_rx_packets ( struct net_device *netdev )
} else {
len = flags & LEN_MASK_V1;
/* Filter any frames that have as destination address a
* local MAC address but are not meant for this NIC */
if ( is_local_ether_addr ( curr_iob->data ) &&
memcmp ( curr_iob->data, netdev->hw_addr, ETH_ALEN ) ) {
free_iob ( curr_iob );
} else {
iob_put ( curr_iob, len );
netdev_rx ( netdev, curr_iob );
}
iob_put ( curr_iob, len );
netdev_rx ( netdev, curr_iob );
}
/* Invalidate iobuf */