david/ipxe
david/ipxe
Archived
1
0
Fork 0
Code

[cmdline] Remove arbitrary limit on the length of image command lines

Browse Source
This commit is contained in:
Michael Brown 2008-06-12 02:12:10 +01:00
parent 031b30898a
commit 4c85017968
1 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/hci/commands/image_cmd.c
View File

@ -49,16 +49,25 @@ enum image_action {
*/
static int imgfill_cmdline ( struct image *image, unsigned int nargs,
char **args ) {
char buf[256];
size_t used = 0;
size_t len;
unsigned int i;
memset ( buf, 0, sizeof ( buf ) );
while ( ( used < sizeof ( buf ) ) && nargs-- ) {
used += snprintf ( &buf[used], ( sizeof ( buf ) - used ),
" %s", *(args++) );
/* Determine total length of command line */
len = 1; /* NUL */
for ( i = 0 ; i < nargs ; i++ )
len += ( 1 /* space */ + strlen ( args[i] ) );
{
char buf[len];
char *ptr = buf;
/* Assemble command line */
for ( i = 0 ; i < nargs ; i++ )
ptr += sprintf ( ptr, " %s", args[i] );
assert ( ptr == ( buf + len - 1 ) );
return image_set_cmdline ( image, &buf[1] );
}
return image_set_cmdline ( image, &buf[1] );
}
/**