david/ipxe
david
/
ipxe
Archived
1
0
Fork 0
Code

[hw] Eliminate polling while waiting for window to open 

Polling for the data-transfer window to become open is wasteful.  We
can eliminate the polling loop by using hw_step() as the handler for
an xfer_window_changed() event.

If the window is already open at the time of instantiation, then
xfer_window_changed() may never be called.  We can cover this case by
using hw_step() as the step() method of a one-shot process.  Since the
signature for an xfer_window_changed() method is identical to the
signature for a process step() method, the same function can be used
for both.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown 2011-06-24 16:51:31 +01:00
parent 019d4c1c18
commit 3915b660fd
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/core/hw.c
View File

@ -36,6 +36,7 @@ static void hw_step ( struct hw *hw ) {
}
static struct interface_operation hw_xfer_operations[] = {
INTF_OP ( xfer_window_changed, struct hw *, hw_step ),
INTF_OP ( intf_close, struct hw *, hw_finished ),
};
@ -43,7 +44,7 @@ static struct interface_descriptor hw_xfer_desc =
INTF_DESC ( struct hw, xfer, hw_xfer_operations );
static struct process_descriptor hw_process_desc =
PROC_DESC ( struct hw, process, hw_step );
PROC_DESC_ONCE ( struct hw, process, hw_step );
static int hw_open ( struct interface *xfer, struct uri *uri __unused ) {
struct hw *hw;