From 1ec2a60614ea0f27843d553d3ee698f9e8d43d79 Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Tue, 21 Mar 2017 15:07:10 +0200 Subject: [PATCH] [eoib] Avoid passing a NULL I/O buffer to netdev_tx_complete_err() Report errors in eoib_duplicate() via netdev_tx_err() rather than netdev_tx_complete_err(), since netdev_tx_complete_err() accepts only valid I/O buffers that are currently in the network device's transmit queue. Signed-off-by: Michael Brown --- src/drivers/net/eoib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/drivers/net/eoib.c b/src/drivers/net/eoib.c index f58e74b7..e8247837 100644 --- a/src/drivers/net/eoib.c +++ b/src/drivers/net/eoib.c @@ -870,8 +870,9 @@ static void eoib_duplicate ( struct eoib_device *eoib, err_post_send: err_path: + list_del ( ©->list ); err_alloc: - netdev_tx_complete_err ( netdev, copy, rc ); + netdev_tx_err ( netdev, copy, rc ); } /**