From 15759e539e2fd0d33ef4f68c92942807f2048a29 Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Wed, 20 May 2015 15:19:47 +0100 Subject: [PATCH] [neighbour] Return success when deferring a packet Deferral of a packet for neighbour discovery is not really an error. If we fail to discover a neighbour then the failure will eventually be reported by the call to neighbour_destroy() when any outstanding I/O buffers are discarded. The current behaviour breaks PXE booting on FreeBSD, which seems to treat the error return from PXENV_UDP_WRITE as a fatal error and so never proceeds to poll PXENV_UDP_READ (and hence never allows iPXE to receive the ARP reply and send the deferred UDP packet). Change neighbour_tx() to return success when deferring a packet. This fixes interoperability with FreeBSD and removes transient neighbour cache misses from the "ifstat" error output, while leaving genuine neighbour discovery failures visible via "ifstat" (once neighbour discovery times out, or the interface is closed). Debugged-by: Wissam Shoukair Tested-by: Wissam Shoukair Signed-off-by: Michael Brown --- src/net/neighbour.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/net/neighbour.c b/src/net/neighbour.c index f70896a1..7f66d999 100644 --- a/src/net/neighbour.c +++ b/src/net/neighbour.c @@ -322,7 +322,7 @@ int neighbour_tx ( struct io_buffer *iobuf, struct net_device *netdev, netdev->name, net_protocol->name, net_protocol->ntoa ( net_dest ) ); list_add_tail ( &iobuf->list, &neighbour->tx_queue ); - return -EAGAIN; + return 0; } }