david/ipxe
david
/
ipxe
Archived
1
0
Fork 0
Code

[fcp] Fix potential memory leaks on error paths 

Functions that instantiate objects generally own one reference to the
object being created.  The error paths must therefore usually call
ref_put() to release this reference.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown 2010-11-03 01:48:38 +00:00
parent 41187aca2c
commit 0654698cd7
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/net/fcp.c
View File

@ -794,6 +794,7 @@ static int fcpdev_scsi_command ( struct fcp_device *fcpdev,
err_xchg_originate:
fcpcmd_close ( fcpcmd, rc );
ref_put ( &fcpcmd->refcnt );
err_zalloc:
err_target:
err_link:
@ -979,6 +980,7 @@ static int fcpdev_open ( struct interface *parent, struct fc_name *wwn,
err_scsi_open:
fcpdev_close ( fcpdev, rc );
ref_put ( &fcpdev->refcnt );
err_zalloc:
fc_ulp_put ( ulp );
err_ulp_get: