From 02de18eb3ef5665b74b45ac5e193643735618fb5 Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Thu, 2 Aug 2007 01:12:42 +0100 Subject: [PATCH] Cope with non-newline-terminated scripts. Print error status using strerror(). --- src/image/script.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/image/script.c b/src/image/script.c index 8e511d21..c8821522 100644 --- a/src/image/script.c +++ b/src/image/script.c @@ -58,6 +58,7 @@ static int script_exec ( struct image *image ) { len = sizeof ( cmdbuf ); if ( len > remaining ) len = remaining; + memset ( cmdbuf, 0, sizeof ( cmdbuf ) ); copy_from_user ( cmdbuf, image->data, offset, len ); /* Find end of line */ @@ -75,8 +76,8 @@ static int script_exec ( struct image *image ) { *eol = '\0'; DBG ( "$ %s\n", cmdbuf ); if ( ( rc = system ( cmdbuf ) ) != 0 ) { - DBG ( "Command \"%s\" exited with status %d\n", - cmdbuf, rc ); + DBG ( "Command \"%s\" failed: %s\n", + cmdbuf, strerror ( rc ) ); goto done; }