From 01496a50282542fbac98b16ed40cbe52d7d6161d Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Wed, 22 Mar 2017 14:41:01 +0200 Subject: [PATCH] [xen] Use standard calling pattern for asprintf() Our asprintf() implementation guarantees that strp will be NULL on allocation failure, but this is not standard behaviour. Detect errors by checking for a negative return value instead of a NULL pointer. Signed-off-by: Michael Brown --- src/interface/xen/xenstore.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/interface/xen/xenstore.c b/src/interface/xen/xenstore.c index 23424a92..a14881fc 100644 --- a/src/interface/xen/xenstore.c +++ b/src/interface/xen/xenstore.c @@ -538,8 +538,7 @@ void xenstore_dump ( struct xen_hypervisor *xen, const char *key ) { child += ( strlen ( child ) + 1 /* NUL */ ) ) { /* Construct child key */ - asprintf ( &child_key, "%s/%s", key, child ); - if ( ! child_key ) { + if ( asprintf ( &child_key, "%s/%s", key, child ) < 0 ){ DBGC ( xen, "XENSTORE could not allocate child " "key \"%s/%s\"\n", key, child ); rc = -ENOMEM;